CBG-4317 uptake fix for TLS without certs for import feed #7192
+62
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@torcolvin Is there an integration test run for this PR to validate the new test works with Couchbase Server? |
adamcfraser
requested changes
Nov 14, 2024
| @@ -451,6 +451,7 @@ func (c *CbgtContext) Stop() { | |||
|
|
|||
| func (c *CbgtContext) RemoveFeedCredentials(dbName string) { | |||
| removeCbgtCredentials(dbName) | |||
| removeCbgtRootCertsForBucket(c.sourceUUID) | |||
There was a problem hiding this comment.
If multiple databases are using the same bucket, this looks like it's going to delete the shared credentials for all when the import listener is stopped for any one of the databases using that bucket.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CBG-4317 use cbgt patch from MB-64126 to allow sharded import feed to function
Integration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/2789/